warpdotdev / warpdotdev/warp

Error when trying to deactivate virtualenv on Fish.

Open
#4,890 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug ready-to-implement triaged
Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Dupe Check
Describe the bug

image

which python3
/opt/homebrew/bin/python3
Python 3.12.3
fish -version
fish, version 3.7.1

Deactivating the virtualenv shows the error.
And this error will show for any commands until the current shell is closed.

Settings/Appearance Prompt -> choosing shell prompt (PS1) makes no difference.
Other terminal has no issues.

Many thanks in advance!

To reproduce
  • set Fish as default shell on Mac OS
  • activate any virtualenv
  • deactivate
Expected behavior

Should not have _old_fish_prompt errors.

Operating system

MacOS

Operating system and version

Mac 13.4.1

Shell Version

fish 3.7.1

Current Warp version

v0.2024.04.30.08.02.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce on macOS with Fish 3.7.1 by activating and deactivating a Python virtualenv, then inspect Warp's Fish shell integration for the _old_fish_prompt error. Done means deactivation completes without the error and later commands remain usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
fish, python, rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.