Completions broken when cursor inside double-quotes

Open
#4,857 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
cli

Research direction

Reproduce the issue on macOS using ls "./<cursor here>" from a directory that is not the home directory, then press Tab. Trace the completion handling for a cursor inside double quotes and verify that the menu lists the current directory contents without breaking quoted input.

Written by the indexing model from the issue text.

Description

area:completions bug needs-info ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

If I have a command in the input like so:

ls "./<cursor here>"

and I press tab, the contents of the completion menu are incorrect.

To reproduce

Go to a dir which is not the home dir

ls "./<cursor here>"

And press Tab

Expected behavior

I should see the contents of the current dir in the autocomplete menu.

Screenshots
Screenshot 2024-04-30 at 11 48 54
Operating system

MacOS

Operating system and version

MacOS 14.4.1 (23E224)

Shell Version

all shells

Current Warp version

v0.2024.04.30.08.01.dev_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.