warpdotdev / warpdotdev/warp

fish abbreviations not setting cursor properly

Open
#4,365 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:ui-framework bug ready-to-implement triaged
Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Discord username (optional)

No response

Describe the bug

In Warpified fish when expanding an abbr with --set-cursor option the % remains untouched and the cursor just moves to the end of the line.

To reproduce
abbr --set-cursor foobar "foo % bar"

then enter foobar followed by a whitespace.

Expected behavior

The cursor moving in place of the % sign.

Screenshots

No response

Operating system

Linux

Operating system and version

Arch

Shell Version

No response

Current Warp version

No response

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Warp on Linux with abbr --set-cursor foobar "foo % bar", then enter foobar followed by whitespace. Trace the fish abbreviation expansion and cursor-placement entry point; done means % is replaced and the cursor lands at that position rather than at the end of the line.

Written by the indexing model from the issue text.

Assessment

Tech stack
fish, rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.