Slow commands finishing when not focused aren't marked as complete

Open
#4,020 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
fish, rust
Domain
cli

Research direction

Reproduce the issue on macOS 13.6.2 with fish 3.6.4 using sleep 10 && echo Done, both with Warp focused and after minimizing it. Trace why the block remains marked as running when the command has finished, and verify that the block closes and the prompt returns without pressing Ctrl-C or Enter.

Written by the indexing model from the issue text.

Description

area:performance bug ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

When a long-running command finishes and Warp is not focused, Warp will act like the command is still running when it has finished. This also affects Warp's feature of getting notifications for long-running commands.

To reproduce
  1. Run sleep 10 && echo Done
  2. Keep Warp focused
  3. Notice the block ends and the prompt is shown again
  4. Run sleep 10 && echo Done
  5. Focus another window or minimise Warp
  6. Focus Warp after 20 seconds
  7. Notice Warp shows Done but the prompt isn't shown and the block is still "running"
  8. Ctrl-C
  9. Notice the tab name changes
  10. Press enter
  11. Notice the block ends and the prompt is shown again
Expected behavior

The block ends when the command ends.

Screenshots

https://github.com/warpdotdev/Warp/assets/18350092/22ea047e-4feb-415f-ac99-2f24c38152c3

Operating system

MacOS

Operating system and version

macOS 13.6.2

Shell Version

fish 3.6.4

Current Warp version

v0.2023.12.19.08.02.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.