Searching in terminal buffer

Open
#3,834 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
bash, macos, rust
Domain
cli, search

Research direction

Start by reproducing the issue on macOS 12.6.1 with bash 3.2.57 using a script that prints more than 500 repeated strings, then exercise the terminal buffer's Cmd+F search with and without “find in selected block.” Done means the search returns the correct match count for the full buffer and selected blocks.

Written by the indexing model from the issue text.

Description

bug ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

I have a script that outputs "msg: ____" every second for about 12,000 seconds

The terminal buffer cmd+f seems to be stuck at 320, even when i have "find in selected block" untoggled

image
To reproduce
  1. run script that outputs > 500 repeated strings
  2. cmd+f for said string
  3. cmd+f does not return correct count
Expected behavior

No response

Screenshots
image
Operating system

MacOS

Operating system and version

12.6.1

Shell Version

bash 3.2.57

Current Warp version

v0.2023.10.31.08.03.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

Just started using warp yesterday

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.