Don't Set CONDA_CHANGEPS1=false if "Honor user's custom prompt (PS1)" is enabled
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
Research direction
No source file or test is named; start by tracing Warp's shell initialization for the CONDA_CHANGEPS1 export shown in the report, using a zsh session with the custom-prompt setting enabled. Reproduce with conda activate myenv and verify that the environment indicator appears without breaking Warp's prompt handling.
Written by the indexing model from the issue text.
Description
Discord username (optional)
No response
Describe the bug
Please disable setting CONDA_CHANGEPS1=false if "Honor user's custom prompt (PS1)" is enabled.
I use starship for my prompt, so I have "Honor user's custom prompt (PS1)" enabled. When I activate a conda env, in every single other terminal, I will see the (myenv) indicator showing what environment I'm in. Not so in Warp. Upon further investigation, Warp is manually setting CONDA_CHANGEPS1=false for every single shell.
# Unset the prompt environment variable: Warp doesn't render the user's default prompt.
# We explicitly unset this for performance optimizations and so that the we can read the
# command directly from the command grid without having to parse the prompt.
export CONDA_CHANGEPS1=false
warp_update_prompt_vars
(This was found via strings /Applications/Warp.app/Contents/MacOS/stable | rg "CONDA_CHANGEPS1").
To reproduce
- Have "Honor user's custom prompt (PS1)" enabled.
- Activate a conda env, ie
conda activate myenv(conda must be installed and "myenv" an environment you've created).
Expected behavior
I expect to see what I see in every other terminal. (myenv) before the prompt. (example from kitty)
Screenshots
No response
Operating system
MacOS
Operating system and version
macOS 13.5
Shell Version
zsh 5.9
Current Warp version
v0.2023.08.01.08.05.stable_02
Regression
No, this bug or issue has existed throughout my experience using Warp
Recent working Warp date
No response
Additional context
No response
Does this block you from using Warp daily?
Yes, this issue prevents me from using Warp daily.
Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)
Yes, this I confirmed this only happens in Warp, not other terminals.
Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e
None
- Dominant language
- Rust
- Stars
- 65.1k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from warpdotdev/warp
-
area:agent area:window-tabs-panes enhancement needs-info os:mac repro:high triaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
warpdotdev/warp#15768 · 3 comments · 1 reaction ·
-
bug factory-auto-implement factory:revops-factory os:mac ready-to-implement repro:high triaged warp:auto-triage-review
Difficulty 1/5 Under an hour Newbie friendliness 90/100
warpdotdev/warp#15697 · 2 comments ·
-
area:editor-notebooks bug repro:high triaged warp:auto-triage-review warp:tracking
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
warpdotdev/warp#13949 · 3 comments ·
-
markdown_parser: unclosed `<u>` markers pair via the emphasis algorithm and delete surrounding text Openarea:editor-notebooks bug ready-to-implement repro:high triaged warp:auto-triage-review
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
warpdotdev/warp#12863 · 2 comments ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
warpdotdev/warp#11969 · 2 comments ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100