warpdotdev / warpdotdev/warp

Line height causing visual breakage

Open
#3,462 6 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug ready-to-implement triaged
Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Discord username (optional)

No response

Describe the bug

Honestly, I'm not even sure if this is a bug, but I mentioned it on Twitter and was told to file an issue here.

Basically, when using a package such as Laravel Prompts, the output is a bit crunched vertically. When I try to increase the line height, it creates gaps in the output. Somehow iTerm handles this gracefully, not sure how though.

I've tried different fonts, but same result.

To reproduce

Output a box in the terminal and start increasing the line height, you'll see gaps in the lines.

Expected behavior

Gaps shouldn't appear, ideally. The line should be continuous.

Screenshots
CleanShot 2023-08-02 at 08 49 51@2x CleanShot 2023-08-02 at 08 50 34@2x

CleanShot 2023-08-01 at 13 31 37@2x

CleanShot 2023-08-01 at 13 32 21@2x

CleanShot 2023-08-01 at 13 33 22@2x

Operating system

MacOS

Operating system and version

Ventura 13.0.1

Shell Version

zsh 5.8.1 (x86_64-apple-darwin22.0)

Current Warp version

v0.2023.07.25.08.03.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

No, this same issue happens in Warp and other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on macOS by rendering a terminal box while increasing line height, using the reported Warp version and comparing the result with iTerm. Since the issue names no files or tests, first locate the terminal rendering and line-height entry points; done means box lines remain continuous without gaps.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.