warpdotdev / warpdotdev/warp

Support session restoration on window close with red button

Open
#3,394 4 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:window-tabs-panes enhancement triaged
Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Discord username (optional)

No response

Describe the bug

Warp won't restore session when used exit button to exit, but when use cmd+Q to exit, it will restore sessions just fine.

To reproduce

won't restore:
step 1: open warp and execute some commands
step 2: use top-left cornet exit red button to exit warp
step 3: use spotlight to reopen warp

can restore:
step 1: open warp and execute some commands
step 2: use cmd+q to exit warp
step 3: use spotlight to reopen warp

Expected behavior

restore session shouldn't be impact by the way to exit warp

Screenshots

No response

Operating system

MacOS

Operating system and version

macOS 13.3 22E252 arm64

Shell Version

zsh 5.9 (x86_64-apple-darwin22.0)

Current Warp version

v0.2023.07.11.08.03.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the session-restoration difference on macOS 13.3 using the red window-close button and cmd+Q, with commands running in Warp. Compare both shutdown paths and trace where session restoration is triggered; done means reopening Warp restores the same session regardless of how the window is closed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.