File path matching not working in some cases

Open
#2,785 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
cli

Research direction

Start by reproducing the issue with the provided mkdir, git init, cd, and ls -G commands from a nested directory on macOS. Trace the file-path matching entry point for colored output whose path is relative to the git root; done means those paths become clickable and open in the configured editor.

Written by the indexing model from the issue text.

Description

bug needs-info ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

For some test output, warp doesn't match the file paths and I can't click through to the editor.
Screenshot 2023-03-17 at 3 07 05 pm

Observations:

  • The path and line numbers are colored in the CLI (path and numbers have different colors)
  • The path is relative to the git repo root, not my CWD. In this case, I'm in a dir called web,
To Reproduce
mkdir -p test/subdir
cd test
git init
cd subdir
ls -G ..

Produces a colored output relative to the git root. The path is not matched

Expected behaviour

Files relative to git root can be clicked and opened in browser of choice

Screenshots

No response

Operating System

MacOS

OS Version

x86_64-apple-darwin22.0

Shell Version

zsh 5.8.1 (x86_64-apple-darwin22.0)

Warp Version

v0.2023.03.07.08.02.stable_03

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.