the link is not parsed correctly, if link is in single quote and followed with ":"

Open
#2,633 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
git, rust
Domain
cli

Research direction

Reproduce the issue in Warp using a link enclosed in a single quote and followed by a colon, as described in the report. Trace the terminal's link-parsing entry point and add or update coverage for this input; done means the parsed link is exactly https://github.com/omnivore-app/omnivore.git/ rather than including the quote and LibreSSL text.

Written by the indexing model from the issue text.

Description

bug needs-info ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

image

The link block is : 'https://github.com/omnivore-app/omnivore.git/':LibreSSL ,

To Reproduce
  1. Git pull in a git repo
  2. get git pull error, tells SSL error
  3. the link is parsed as 'https://github.com/omnivore-app/omnivore.git/':LibreSSL but not https://github.com/omnivore-app/omnivore.git/
Expected behaviour

The link should be : https://github.com/omnivore-app/omnivore.git/

Screenshots

No response

Operating System

MacOS

OS Version

No response

Shell Version

No response

Warp Version

No response

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.