Launch Configuration is not working with Hotkey / Pin to bottom Feature

Open
#2,473 5 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
macos
Domain
desktop

Research direction

Start by reproducing the saved Launch Configuration flow with Hotkey Window enabled and Pin to bottom selected on macOS. Trace how the pinned bottom window handles hotkey launches and how saved configurations open, then verify that the configuration creates a new tab in that window rather than a separate window.

Written by the indexing model from the issue text.

Description

area:settings-keybindings bug ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

Open a saved Launch Configuration will open a new window, it is not replacing the pinned to the bottom window I'm using.

To Reproduce
  • Save a Launch Configuration
  • Go to Settings > Features > Hotkey Window and toggle it on. Set a hotkey and the option "Pin to bottom".
  • Press the hotkey
  • Press ^ + CMD + L and open your saved Launch Configuratoin
Expected behaviour

The Launch Configuration should open a new tab with it's layout in the pinned to the bottom window.

Screenshots

CleanShot 2023-01-11 at 11 40 01

The saved configuration is opened as a new window instead of adding a new tab to the bottom window.

Operating System

MacOS

OS Version

13.1

Shell Version

zsh 5.9 (arm-apple-darwin21.3.0)

Warp Version

v0.2023.01.03.08.03.stable_01

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.