venv is diactivated, but (venv) is still prompted

Open
#2,459 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
python, zsh
Domain
cli

Research direction

Reproduce the issue on macOS with Python 3, source venv/bin/activate, and deactivate in zsh. Start by tracing Warp's virtual-environment prompt handling and compare the prompt before activation and after deactivation; done means (venv) is removed after deactivate.

Written by the indexing model from the issue text.

Description

area:shell-terminal bug needs-info ready-to-implement triaged
Discord username (optional)

rive_n#8294

Describe the bug

First of all, let's create a simple Python3 project:
python3 -m venv venv (here we need to have py venv installed)

After - let's use this virtual env:
source venv/bin/activate

We will see that now we are not:
user@something  ~/Desktop/tools, instead we are:
(venv). Okay, let's move forward:

Let's deactivate venv:
deactivate.
After that we are still (venv), not user@something  ~/Desktop/tools.

To Reproduce
  1. Create python3venv;
  2. Activate it via source;
  3. diactivate it.
Expected behaviour

User should see user@something  ~/Desktop/tools instead of (venv).

Screenshots

No response

Operating System

MacOS

OS Version

12.1

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.3.0)

Warp Version

v0.2023.01.03.08.03.stable_01

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

Ignore

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.