Broken pipe in ssh+vim session does not restore the terminal.

Open
#2,379 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust, vim, zsh

Research direction

Start by reproducing the reported sequence on macOS: open Warp, SSH to a remote server, run vim, and interrupt the connection. Trace the terminal session's behavior after the broken pipe; done means Warp restores command completion, copy/paste blocks, and the shell prompt.

Written by the indexing model from the issue text.

Description

area:shell-terminal area:ssh bug needs-info ready-to-implement SSH triaged
Discord username (optional)

geodesic#4378

Describe the bug

If my ssh connection drops out while in vim, and we get a broken pipe, warp does not restore correctly. For example the drop down command completion doesnt work, no copy paste blocks, no shell prompt, basically like a remnant of being in the vim environment (see screenshot).

To Reproduce
  1. open warp
  2. ssh to some remote server
  3. open vim on remote
  4. kill internet connection so ssh connection drops
Expected behaviour

I would expect warp to restore itself.

Screenshots

image

Operating System

MacOS

OS Version

13.0.1

Shell Version

zsh 5.8.1

Warp Version

v0.2022.12.13.08.04.stable_01

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.