BUG: shell breaks if typing while SSH is starting

Open
#2,290 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
zsh
Domain
cli

Research direction

Start by reproducing the SSH-to-host flow while typing before the remote shell finishes starting, then press Return as described. Done means the typed input is handled without breaking WARP's multiline editing, blocks, or other special shell interaction.

Written by the indexing model from the issue text.

Description

area:ssh bug needs-info ready-to-implement SSH triaged
Discord username (optional)

isaac-mcfadyen#4321

Describe the bug

If the user is typing while an SSH session is starting, the shell breaks on hitting enter.

To Reproduce
  1. SSH to any host using WARP.
  2. While the SSH session is starting/connecting, start typing. Typing anything will reproduce this bug.
  3. Once the shell starts (in some cases it may hang at "starting shell", in other cases it connects properly) hit Return.
  4. Observe as the shell "breaks", meaning you now get a regular interface (no multiline editing, no blocks, etc).
Expected behaviour

Typed commands are buffered until the remote shell starts (at least I assume that's what causing this?)

This mainly affects me because I start typing while my shell is connecting, because I know the commands I want to execute and my network is slow so SSH connection starts take a few seconds.

Screenshots

Observe how all of WARP's special editing capabilities are now gone and I can only interact like a normal shell. In normal cases (i.e. when I don't start typing as the shell starts) WARP's editing capabilities work fine.

Screenshot 2022-12-04 at 08 46 48
Operating System

MacOS

OS Version

Ventura 13.0

Shell Version

zsh 5.8.1

Warp Version

v0.2022.11.29.08.03.stable_03

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.