Command spacing inconsistent across fonts, font sizes and line spacings

Open
#2,095 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
macos, nodejs, rust, zsh

Research direction

Reproduce the issue with a NodeJS project by changing font size, line spacing, and supported fonts, then observe dependency-install progress output. Trace the terminal rendering path responsible for command progress bars and verbose output. Done means progress remains fully visible across the reported font and spacing settings, with regression coverage if the relevant tests are found.

Written by the indexing model from the issue text.

Description

area:ui-framework bug needs-info ready-to-implement triaged
Discord username (optional)

OneComputerGuy#5692

Describe the bug

Progress for commands have inconsistent behavior when using other fonts/font size/line spacing.

Using external (supported) fonts, sometimes it ends up with progress bars/command verbose outside the viewing area, which could be problematic when trying to diagnose or catch any issue in real time.

Using the default font, if the size is increased enough (from 15 starts) and line spacing is more than 1.5 (this could be a usual scenario with users with visual impairment), the command gets cut. So far I've seen this behavior in NodeJS as seen in the image below

To Reproduce
  1. Change the font size to 15 or above and change the line height to 1.5 or more
  2. Initialize a NodeJS project (npm init)
  3. Install any dependency or try to install any existing dependency
Expected behaviour

Terminal should show the progress bar completely.

Screenshots

spacing-bug

Operating System

MacOS

OS Version

MacOS Ventura 13.0.1 (22A400)

Shell Version

zsh 5.8.1 (x86_64-apple-darwin22.0)

Warp Version

v0.2022.11.08.08.07.stable_02

Additional context

default font it overflows outside boundaries when the font size is set to 14 or above and the line spacing set to 1.5 or above.

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.