Autocomplete stops at last directory when using `zip`

Open
#2,039 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
macos, zsh
Domain
cli

Research direction

Reproduce the issue with zip archive.zip, first selecting images and then trying to select some_file.txt; no source file or test is named in the report. Trace the CLI autocomplete handling for the first file argument and compare it with later arguments. Done means files inside the selected directory are suggested for the first argument on macOS with zsh.

Written by the indexing model from the issue text.

Description

area:completions bug needs-info ready-to-implement triaged
Discord username (optional)

Joxtacy#4160

Describe the bug

When I use the zip CLI and want to add several individual files to an archive, the autocomplete stops once it reaches the last directory in the list and will not start autocompleting for files.

This seems to only be an issue with the first argument of files passed to the zip CLI.

To Reproduce
  1. Start typing zip archive.zip
  2. Use suggestions to find the file you want to add.
  3. Once you reach the last directory, files will not show up as suggestions.

Example:

Have a directory structure like the following.

.
└── images
    └── some_file.txt

1 directory, 1 file

Warp will suggest images, but once that is done, it will not autocomplete for some_file.txt.

Note: This seems to only happen for the first file argument. Add any more and they will get suggestions as expected.

Expected behaviour

I would expect Warp to also give suggestions on the files within the directory.

Screenshots

Screenshot 2022-11-02 at 17 05 36
Example of it not suggesting some_file.txt.

Screenshot 2022-11-02 at 17 07 59
Example of suggestion working for the second and all other arguments.

Operating System

MacOS

OS Version

12.6

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.10.25.08.06.stable_03

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.