Link recognition does not include the tailing /

Open
#1,971 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
cli

Research direction

Reproduce the issue in Warp by running echo http://www.example.com/dir/ and hovering over the link. Trace the link-recognition or URL-parsing entry point, then verify that the complete URL, including its trailing slash, is recognized and handled as the link target.

Written by the indexing model from the issue text.

Description

bug needs-info ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

Tailing / of a link is not included in Warp. For some web servers, the tailing / is required, e.g. html hosting of Alibaba Cloud OSS.

http://domain.com/dir/    =    http://domain.com/dir/index.html
this is expected

but
http://domain.com/dir    =    http://domain.com/dir (file)
it gets a 404 response...
To Reproduce
  1. open Warp
  2. Run command echo http://www.example.com/dir/
  3. Move mouse over the link
Expected behaviour

The whole http://www.example.com/dir/ is recognized as a link.

Screenshots
image
Operating System

MacOS

OS Version

12.6

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.10.11.08.13.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.