fish not loading properly when Warp starts

Open
#1,869 24 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
fish, macos

Research direction

Reproduce the startup behavior on macOS using ~/.config/fish/conf.d/abbr.fish and the echo command from the issue, comparing Warp startup with invoking fish inside Warp and opening iTerm2. Trace Warp's shell startup entry point to determine why the file is skipped initially. Done means the echo runs and fish abbreviations load when Warp starts.

Written by the indexing model from the issue text.

Description

area:shell-terminal area:warp-drive area:window-tabs-panes bug ready-to-implement triaged
Discord username (optional)

No response

Describe the bug

I have a file that I expect to be loaded by fish every time fish starts, namely: ~/.config/fish/conf.d/abbr.fish which loads my abbreviations. It isn't loaded.

When I use Warp this file isn't loaded initially, but if I start a Warp-session and invoke fish the file is indeed loaded. The easiest way to test this is to create that file and add a line, echo "Setting abbreviations" at the top and re-start Warp. The line will not be echoed. Invoking fish will however result in the line being echoed.

Consequently, opening a new ITerm2 window fill echo the line initially which is what is expected.

To Reproduce
  1. Create debugging echo,
echo "echo \"Setting abbreviations\"" >> ~/.config/fish/conf.d/abbr.fish
  1. Re-start Warp, observe that nothing is printed
  2. Invoke Fish inside Warp, observe that the line is printed
  3. Start another Terminal such as ITerm2, observe that the line is printed
Expected behaviour

On Step 2 in Reproduce see that the echo line is executed

Screenshots
Screenshot 2022-09-23 at 07 28 01
Operating System

MacOS

OS Version

12.5.1

Shell Version

fish, version 3.5.1

Warp Version

v0.2022.09.20.08.08.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.