SSH autocompletion not working when user@ is entered first

Open
#1,765 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
macos, zsh
Domain
cli

Research direction

Start by reproducing ssh username@ followed by Tab on macOS with entries in ~/.ssh/known_hosts, then compare it with ssh followed by Tab, which is reported to work. Trace the terminal's SSH completion path and verify that hostname completion also works after a username and @ are entered.

Written by the indexing model from the issue text.

Description

area:completions area:ssh bug needs-info ready-to-implement triaged
Discord username (optional)

Pfogl#3928

Describe the bug

When user@ is added to the ssh command, auto completion isn't working.

ssh username@ + Tab

To Reproduce

Setup:
none needed besides warp installed and some entries in the ~/.ssh/known_hosts

Repro:

  1. type ssh, then the username@
  2. type in some letters of the known hostname.
  3. Tab, fails autocomplete
Expected behaviour

autocompletion for hostname works ootb after the ssh username@ as with Terminal.app

Screenshots

https://www.loom.com/share/1d602a85a9d14c8b995ca93a67fcdd20

Operating System

MacOS

OS Version

12.5.1

Shell Version

zsh 5.8.1

Warp Version

v0.2022.08.23.08.06.stable_01

Additional context

ssh + Tab works as expected and gathers the hostnames from the ~/.ssh/config & ~/.ssh/known_hosts correctly for autocompletion.

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from warpdotdev/warp

All issues in warpdotdev/warp

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.