Permalinks only really work for dark themes
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Reproduce the issue with echo '\033[30mHello, World!\033[m' in a light theme, then compare the local preview with the permalink at the reported URL. Done means permalink output remains readable on a light background or provides a documented theme/background choice.
Written by the indexing model from the issue text.
Description
Discord username (optional)
fabjan#6411
Describe the bug
I use a light theme and some programs (e.g. [lsd]) which output black text, not just foreground.
When I create a permalink it shows up as black text on a black background: https://app.warp.dev/block/mAXXTBrDlSqD9I8yLbEOUz
[lsd]: https://github.com/Peltoche/lsd
To Reproduce
Steps to reproduce:
- Switch to a light theme (optional)
- Run
echo '\033[30mHello, World!\033[m' - Create a permalink (notice how the preview looks fine)
- View the permalink
The problem is not related to the light theme itself, but without it the text will look bad locally as well as in the permalink and make no sense.
Expected behaviour
I would expect the permalink to either:
A. Use the theme it was created from
B. Have a view that lets users pick a theme
C. Let users pick a white or black background
Since themes can have background images, maybe alternative A is too much to expect.
Screenshots
No response
Operating System
MacOS
OS Version
12.4
Shell Version
zsh 5.8.1 (x86_64-apple-darwin21.0)
Additional context
No response
Warp Internal (ignore): linear-label:24888f54-df93-45d5-9bdd-e38f740cac19
No response
- Dominant language
- Rust
- Stars
- 65.1k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from warpdotdev/warp
-
area:agent area:window-tabs-panes enhancement needs-info os:mac repro:high triaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
warpdotdev/warp#15768 · 3 comments · 1 reaction ·
-
bug factory-auto-implement factory:revops-factory os:mac ready-to-implement repro:high triaged warp:auto-triage-review
Difficulty 1/5 Under an hour Newbie friendliness 90/100
warpdotdev/warp#15697 · 2 comments ·
-
area:editor-notebooks bug repro:high triaged warp:auto-triage-review warp:tracking
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
warpdotdev/warp#13949 · 3 comments ·
-
markdown_parser: unclosed `<u>` markers pair via the emphasis algorithm and delete surrounding text Openarea:editor-notebooks bug ready-to-implement repro:high triaged warp:auto-triage-review
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
warpdotdev/warp#12863 · 2 comments ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
warpdotdev/warp#11969 · 2 comments ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100