wallabag / wallabag/android-app
Consider using WebViewAssetLoader for image cache
Open
- Dominant language
- Java
- Stars
- 587
- Forks
- 276
- PR merge metrics
- No merged PRs in 30d
Description
Using [file access](https://github.com/wallabag/android-app/pull/1118) in WebView has some security implications. Not serious in case of wallabag (no storage permissions).
[WebViewAssetLoader](https://developer.android.com/reference/androidx/webkit/WebViewAssetLoader) seems to be a proper way to do it. Probably won't even need to replace images in HTML.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.