walkor / walkor/webman

Show deprecated errors in PHP 8.4

Open
#423 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.7k
Forks
251
PR merge metrics
No merged PRs in 30d

Description

Released 21 Nov 2024
https://www.php.net/releases/8.4/en.php

It's working OK with PHP 8.4, but show deprecated warnings:
```
Running docker container with cpu set:
webman: PHP Deprecated: Webman\Config::load(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Config.php on line 56
webman: Deprecated: Webman\Config::load(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Config.php on line 56
webman: Deprecated: Webman\Config::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Config.php on line 224
webman: PHP Deprecated: Webman\Config::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Config.php on line 224
webman: Workerman[/webman/start.php] start in DEBUG mode
webman: ------------------------------------------ WORKERMAN -------------------------------------------
webman: Workerman version:4.2.0 PHP version:8.4.1 Event-Loop:\Workerman\Events\Event
webman: ------------------------------------------- WORKERS --------------------------------------------
webman: proto user worker listen processes status
webman: tcp root webman http://0.0.0.0:8080 8 [OK]
webman: ------------------------------------------------------------------------------------------------
webman: Press Ctrl+C to stop. Start success.
webman: PHP Deprecated: Webman\Route::group(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 208
webman: PHP Deprecated: Webman\Route::disableDefaultRoute(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 282
webman: PHP Deprecated: Webman\Route::isDefaultRouteDisabled(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 318
webman: PHP Deprecated: Webman\Route::group(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 208
webman: PHP Deprecated: Webman\Route::disableDefaultRoute(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 282
webman: PHP Deprecated: Webman\Route::isDefaultRouteDisabled(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 318
webman: PHP Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullablPHP Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: e type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: PHP Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: Deprecated: Webman\Route::group(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 208
webman: Deprecated: Webman\Route::disableDefaultRoute(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 282
webman: Deprecated: Webman\Route::isDefaultRouteDisabled(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 318
webman: Deprecated: Webman\Route::group(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 208
webman: Deprecated: Webman\Route::disableDefaultRoute(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 282
webman: Deprecated: Webman\Route::isDefaultRouteDisabled(): Implicitly marking parameter $app as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route.php on line 318
webman: Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: Deprecated: Webman\Route\Route::param(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Route/Route.php on line 149
webman: Deprecated: Webman\App::getCallback(): Implicitly marking parameter $route as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/App.php on line 301
webman: Deprecated: Webman\App::getCallback(): Implicitly marking parameter $route as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/App.php on line 301
webman: PHP Deprecated: Webman\App::getCallback(): Implicitly marking parameter $route as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/App.php on line 301
webman: PHP Deprecated: Webman\App::getCallback(): Implicitly marking parameter $route as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/App.php on line 301
webman: PHP Deprecated: Webman\Context::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Context.php on line 90
webman: PHP Deprecated: Webman\Context::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Context.php on line 90
webman: Deprecated: Webman\Context::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Context.php on line 90
webman: Deprecated: Webman\Context::get(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Context.php on line 90
webman: Deprecated: Webman\Http\Response::exception(): Implicitly marking parameter $exception as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Http/Response.php on line 80
webman: PHP Deprecated: Webman\Http\Response::exception(): Implicitly marking parameter $exception as nullable is deprecated, the explicit nullable type must be used instead in /webman/vendor/workerman/webman-framework/src/Http/Response.php on line 80
```

From Techempower benchmark
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/11971699372/job/33377071440?pr=9416

PD: fail query and update tests in the bench

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the PHP 8.4 startup warnings and inspect the referenced files under webman-framework/src/, including Config.php, Route.php, Route/Route.php, App.php, Context.php, and Http/Response.php. Start with the deprecated nullable-parameter reports, then run the benchmark's failing query and update tests. Done means the deprecated warnings are resolved and those benchmark tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.