walkor / walkor/webman

webman 1.x vendor项目结构感觉有些乱 一点小建议

Open
#328 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.7k
Forks
251
PR merge metrics
No merged PRs in 30d

Description

我看到在vendor目录结构下,存在webman workerman两个文件夹,

其中webman里面存放的都是安装的插件类,并且workerman里面还存在一个webman-framework,workerman文件夹,

感觉这种有些乱啊,而且当前我看到webman-framework都升级1.4了,但是webman还是1.3.9

其实不应该直接在vendor文件夹下,只存在一个webman-framework文件夹吗,里面包含workerman文件夹,

以及其他的一些核心库组件,然后更新迭代的时候,只更新webman版本就可以了,现在搞两个感觉有一些不杂乱

或者根目录只有一个workerman文件夹,毕竟是依赖于这个核心,然后在workerman->webman-framework文件夹下存在大部分核心库就可以了,比如路由的,事件的这样!

@walkor

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the vendor directory layout described in the issue, especially the webman and workerman trees and the nested webman-framework package. First determine the intended dependency ownership and versioning model; the work is done only when the maintainers agree on a concrete structure and the package layout and upgrade behavior are consistent with it.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.