walkor / walkor/webman-framework
Breaking change in app v1.4
Open
- Dominant language
- PHP
- Stars
- 148
- Forks
- 68
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 3
Description
`TypeError: Webman\App::__construct(): Argument #1 ($request_class) must be of type string, Workerman\Worker given, called in /webman/start.php on line 55 and defined in /webman/vendor/workerman/webman-framework/src/App.php:96`
Also the new App construct have no container.
Incompatible webman-framework and webman.
https://github.com/walkor/webman-framework/blob/master/src/App.php#L96
https://github.com/walkor/webman/blob/master/start.php#L97
And it's a breaking change, so need to be a major version and not a minor version (1.4)
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.