waldronlab / waldronlab/bugSigSimple

createTaxonTable - wide vs. narrow form

Open
#28 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
R
Stars
4
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Right now, createTaxonTable() outputs a very wide tibble with the entire taxonomy of the taxon presented as columns 7-13. This has some issues:

  • It does not support domain which was added to the taxonomy so all the taxonomy is currently wrong
  • It includes a column called "n_signatures" which I'm not sure what this means
  • It also includes the metaphan name which feels unnecessary

Changes to this function should include:

  • Remove n_signatures if it's not displaying anything useful
  • Add an argument like "format = 'Full'/'Simple' " where full displays the full taxonomy columns and metaphlan name while simple only displays columns 1-6 and "Simple" is the default for that argument

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the createTaxonTable() entry point and inspect how its current columns are assembled, including the taxonomy, n_signatures, and metaphlan name. Check how domain is represented in the taxonomy before deciding the table shapes. Done means the default Simple format returns columns 1–6, while Full includes the requested taxonomy columns and metaphlan name, with n_signatures resolved as specified.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.