w3c / w3c/json-ld-api

Changes to the algorithms that will need their own PRs

Open
#613 1 comment 0 reactions 1 assignee View on GitHub

@davidlehn is already working on this.

Since Aug 7, 2024.

defer-future-version spec:substantive substantive:class 3 test:missing-coverage test:needs implementation test:needs tests
Dominant language
HTML
Stars
106
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Some of these assume changes to the algorithms that will need their own PRs:

  • Tests expand/er57 and er58 along with toRdf/er57 and er58 need a check to be sure that the value is an array, or generate the invalid set or list object error. The presumed semantics are that each array value becomes its own JSON value.
  • Test compact/ej01 is expected to raise multiple JSON literals because the term didn't use @set. This is arguably a breaking change as any data that did this before would now fail (of course two JSON values on input would now be one JSON value on output). This will certainly require checks in the compaction algorithm.
  • Test compact/js07 (and others) also change the behavior to preserve the array value.

Originally posted by @gkellogg in https://github.com/w3c/json-ld-api/issues/559#issuecomment-2257193925

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.