expansion algorithm checking language map value against BCP47
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 106
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
In the expansion algorithm, while processing language mappings in step 13.7 and substeps, a variable name seems to be swapped:
Step 13.7.4.2.3 says to check item as being well-formed accoding to BCP47. This implies that item is a language tag. However, it is defined in step 13.7.4.2 that item comes from the language value, i.e. the value which is mapped to a language tag, not the language tag itself. The language tag is actually in language, which should thus be checked instead of item.
I think <var>item</var> should be replaced with <var>language</var> on the following line:
https://github.com/w3c/json-ld-api/blob/9e5eae38b68656671dfc60042b98e1bffb45197a/index.html#L2882
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open index.html around line 2882 and read expansion algorithm step 13.7.4.2.3 alongside the definitions of language and item in step 13.7.4.2. Confirm which variable is the language tag checked against BCP47. Done means the step checks language rather than item, with the specification wording remaining consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100