`selectAll` command should be disabled if no selection exists on the context object
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 202
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
The spec for queryCommandEnabled states that all commands in the Miscellaneous section are always enabled. However, the steps for selectAll require that document.getSelection() does not return null. My suggestion is to disable the command whenever there is no selection available to work with.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked queryCommandEnabled section in the execCommand specification and compare its Miscellaneous command rule with the selectAll steps. Determine how the specification should handle a null document selection, then update the relevant wording so the enabled state and selectAll requirements agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100