[web-animations-2] Makes finish and cancel event times CSSNumberish
Nobody has claimed this yet.
- Dominant language
- Bikeshed
- Stars
- 4.9k
- Forks
- 816
- PR merge metrics
- PR metrics pending
Description
Per spec, the finished event's currentTime is the current time of the animation, and the finished event's timelineTime is the current time of timeline. Same story for a cancel event. With https://github.com/w3c/csswg-drafts/pull/6479 (https://github.com/w3c/csswg-drafts/issues/6458), the animations current time becomes CSSNumberish, yet the times in AnimationPlaybackEvent are declared as nullable doubles. These should be CSSNumberish as well. This change is backward compatible for monotonic timelines, but is required to support progress-based timelines, where current time must be expressed as a percentage and not a double in ms.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked CSSWG change and locating the AnimationPlaybackEvent definition in the repository. Check the finish and cancel event time members against the specification text; done means the relevant nullable time declarations use CSSNumberish and remain consistent for both events.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- documentation
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100