w3c / w3c/csswg-drafts

[css-values] Spec does not reject duplicate `<request-url-modifier>`s, but WPT does

Open
#12,151 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Edits Needs Testcase (WPT) topic: urls
Dominant language
Bikeshed
Stars
4.9k
Forks
816
PR merge metrics
PR metrics pending

Description

This test requires that a url() with more than one of the same <request-url-modifier> be treated as invalid, but I can't find anything in the spec that says this is invalid. The 3 major engines all pass these tests, so evidently that's the desired behaviour, but it'd be good to specify it. Correction: The 3 major engines pass that test because they don't support url-modifiers at all. So it's not established whether the test behaviour is what's wanted. 😅

The <url> and <url-modifier> definitions in CSS Values 4 do not place any requirements on repeated modifiers.

Likewise, the definitions in CSS Values 5 of <request-url-modifier>s do not say anything about more than one of a given type appearing in a url().

cc: @weinig as you wrote that particular test.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CSS Values 4 and definitions, then compare the CSS Values 5 definitions with url-request-modifiers-invalid.sub.html in WPT. Review the discussion and determine whether repeated modifiers should be invalid; done means the relevant specification text clearly resolves that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.