example 79 is invalid because is uses 'width', 'height' property on Image (they are only defined as in Domain of Link)
Open
@evanp is already working on this.
Since Aug 2, 2023.
Next version
- Dominant language
- HTML
- Stars
- 313
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Description
Please Indicate One:
- Editorial
- Question
- Feedback
- Blocking Issue
- Non-Blocking Issue
Please Describe the Issue:
- via https://github.com/gobengo/activitystreams2-spec-scraped/issues/15
- the vocabulary sepc defines 'width' and 'height' properties as having a Domain of Link
- but ex 79 and 80 use these properties on an Object type ('Image'), which is not in the domain of these properties
recommendations:
- definitely: fix example 79 and 80 to either not use width/height on Image, or else to have the Image.url value be a Link, and put the height/width on there
- maybe: consider expanding the domain of 'width', 'height' to include
Image. While this may be tempting... I don't think it's strictly necessary. It's nice to be able to describe an Image that might have multiple URLs to embed with different sizes, e.g. to render the Image + many Links into a
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.