w3c / w3c/ServiceWorker

Function signature change: reading all bytes from a stream

Open
#1,666 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Bikeshed
Stars
3.6k
Forks
324
Avg merge
14d 22h
Merged PRs (30d)
1

Description

The signature of reading all bytes had changed:
https://github.com/whatwg/streams/pull/1250

It now accepts successSteps and failureSteps instead of returning a Promise, in an attempt to decouple streams from JS when appropriate.

Opening this issue since this spec uses that function

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies the Service Worker specification's use of “reading all bytes” and links WHATWG Streams PR #1250. Locate that reference in the specification, compare it with the updated successSteps/failureSteps signature, and verify the old Promise-returning form is no longer used.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.