w3c / w3c/ServiceWorker

fetch-frame-resource.https.html has a long timeout to detect page load failed

Open
#1,194 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Bikeshed
Stars
3.6k
Forks
324
Avg merge
14d 22h
Merged PRs (30d)
1

Description

Currently fetch-frame-resource.https.html uses a setTimeout of 10 seconds in order to detect that a page load failed (the failure page is considered cross-origin by some browsers, so timeout was needed). Therefore the lower bound of the test completing is 10 seconds. This seems long. Chromium's default test timeout is 6 seconds for Release builds.

The timeout was originally 1 second here, then moved to 5 seconds here and then 10 seconds here.

I could mark this as a Slow test, but am a bit reluctant and would like the test to be faster. I'm wondering if anything's changed in Mozilla's infra recently that means we might be able to explore returning the timeout to 1 second?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with fetch-frame-resource.https.html and inspect its 10-second setTimeout and failure-detection flow. Review the linked historical changes and Mozilla bug, then run the test while evaluating whether a shorter timeout, potentially 1 second, remains reliable. Done means the test completes faster without falsely reporting page-load failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, javascript
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.