vx-lang / vx-lang/Vx

Vec has no drop: free() is manual, and TYPE_NEEDS_DROP is reserved but never set

Open
#495 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core-lang enhancement stdlib
Dominant language
Rust
Stars
14
Forks
2
Avg merge
12h 42m
Merged PRs (30d)
61

Description

Noted while answering how one allocates a growable container. Vec<T> (stdlib/std/vec.vx) is the std::vector analogue -- { data: *mut T, len: i32, capacity: i32 }, doubling growth through vx_vec_grow with the byte-size math overflow-checked in Rust -- and it works: a program that pushes, gets, sets and sums runs correctly on the flat path through the JIT.

What it does not have is a destructor. free() is a method the programmer calls:

let mut v : Vec<i32> = Vec<i32>::new();
v.push(10);
v.free();          // required; nothing calls it for you

Consequences today:

  • a Vec that goes out of scope leaks,
  • a double free() is not caught,
  • free() after a move is not caught.

There is a TYPE_NEEDS_DROP bit reserved at src/gid.rs:51, in word 3 of the TypeId where it would participate in type identity. Nothing sets it -- the only references in the tree are its definition and one unit test asserting the bit round-trips. So the mechanism is reserved and unimplemented rather than partially wired.

Filing as the tracking point for the decision: whether Vx gets scope-based drop (the bit exists for it), or stays explicit-free with the linear-type checker made to catch use-after-free and double-free, which is the cheaper half and would close the silent cases. Vec::free already zeroes data/len/capacity, so a double free is currently a no-op rather than a crash -- which hides it.

Related: Vx#487 (iter.vx does not type-check standalone), which is the iterator surface over the same container.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with stdlib/std/vec.vx and src/gid.rs:51, then inspect the unit test that checks TYPE_NEEDS_DROP round-tripping. Compare the scope-based drop and explicit-free alternatives described in the issue, including the linear-type checker and related iterator issue Vx#487. Done requires an agreed ownership model and implementation of its safety checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.