vx-lang / vx-lang/Vx

decision: the memory space stays out of the flat path's tensor identity (RFC §3.4 withdrawn)

Open
#462 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

codegen question
Dominant language
Rust
Stars
14
Forks
2
Avg merge
12h 42m
Merged PRs (30d)
61

Description

The spelling RFC's §3.4 asked for the resolved memory space in tensor_gid. The placement rides on the TensorAlloc instruction on the flat path (src/hir/flatten.rs, the alloc's spare operand), the emitted memref carries no space, and the mangler excludes placement on purpose. flat_matches_ast_two_tensors_differing_only_in_placement in tests/integration_test/flat_codegen_differential.rs compiles two tensors that differ only in placement in one program and passes on both paths, so the change would split TensorMap entries without changing a byte of output. I withdrew it (review §1.3) rather than ship an identity change with no observable effect.

If the bounded-extents work later needs the space in the identity (a bound derived from a machine-file figure is one such case), this is where it goes. Confirm or reopen.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the placement handling in src/hir/flatten.rs and the flat-path identity behavior, then run flat_matches_ast_two_tensors_differing_only_in_placement in tests/integration_test/flat_codegen_differential.rs. The current issue records a withdrawn RFC change; done means confirming that placement should remain excluded, or reopening the identity work if bounded extents require it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.