vuetifyjs / vuetifyjs/vuetify

[Feature Request] Define sass variables based on css variables where possible in Vuetify v3

Open
#14,136 1 comment 11 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

sass T: feature
Dominant language
TypeScript
Stars
41k
Forks
7.1k
Avg merge
1d 21h
Merged PRs (30d)
11

Description

Problem to solve
  • Allows per element overriding of variables
  • No more need to manually import and compile sass just to override variables
  • Binding css variables in Vue 3 allows for simpler dynamic and computed styles
Proposed solution

Define sass variables based on css variables where possible. example:
instead of:

$icon-size: 24px !default;
--v-icon-size: 24px;
$icon-size: var(--v-icon-size, 24px) !default;

Since this is a breaking change in some instances, ideally it should be implemented before stabilizing v3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.