voxpupuli / voxpupuli/puppet-python

Could not evaluate: Working directory <virualenv> does not exist!

Open
#615 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
196
Forks
372
Avg merge
1d 18m
Merged PRs (30d)
4

Description

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 2019.8
  • Ruby: 2.5.7-1
  • Distribution: ---
  • Module version: v6.1.0

How to reproduce (e.g Puppet code you use)

python::pyvenv { $_virtualenv:
  ensure   => 'present',
  version  => $pythonconfig::package_ensure,
  venv_dir => $_virtualenv,
}

python::pip { $pkgname:
  ensure       => $ensure,
  pkgname      => $pkgname,
  virtualenv   => $_virtualenv,
  pip_provider => 'pip3',
  require      => Python::Pyvenv[$_virtualenv]
}

python::pip { "certifi for venv ${_virtualenv}":
  ensure       => 'present',
  pkgname      => 'certifi',
  virtualenv   => $_virtualenv,
  pip_provider => 'pip3',
  require      => Python::Pip[$pkgname]
}

What are you seeing

Issue only occurs when running Puppet in noop mode.
The following error occurs:

Could not evaluate: Working directory <virtualenv> does not exist!

When running Puppet in normal mode the virtual environment is created and all dependencies are installed.

Looks like the evaluation on the $cwd parameter in the exec in https://github.com/voxpupuli/puppet-python/blob/master/manifests/pip.pp is not working as expected.

What behaviour did you expect instead

No error message and a successful noop run when deploying a new virtual environment.

Output log

Any additional information you'd like to impart

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in manifests/pip.pp, focusing on the exec resource and its $cwd evaluation during Puppet noop runs. Reproduce the virtualenv and pip resource scenario in noop mode, then verify that a new virtual environment produces no missing-working-directory error while normal mode still installs dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, ruby
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.