Puppet pre-releases causing corrective changes

Open
#549 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python, ruby
Domain
devops

Research direction

Start by reproducing the pip version checks shown in the issue and then locate the repository code that compares the available and installed pip versions. Done means pre-releases no longer cause repeated corrective changes, while any requested option for installing pre-releases remains consistent with the check behavior.

Written by the indexing model from the issue text.

Description

Pip pre releases are set as the latest available package by puppet.
This is done by following command

pip --log /tmp/pip.log install pip==notreallyaversion 2>&1 | grep -oP "\(from versions: .*\)" | sed -E "s/\(from versions: (.*?, )*(.*)\)/\2/g" | tr -d "[:space:]") = $(pip freeze --all | grep -i -e ^pip== | cut -d= -f3 | tr -d '[:space:]'

As of time of writing i got 20.2b1
however when you try to upgrade you dont get the pre release but latest stable version as that is not tagged latest version
https://pypi.org/project/pip/#history

Thus puppet tries to correct this each time and you get a coorective change.

I think the check command should be changed so the pre releases are excluded from the latest version check. Or have the option to install pre-releases and keep the old check.

I checked and following command gave me the latest release:

pip --log /tmp/pip.log install pip==notreallyaversion 2>&1 | grep -oP "\(from versions: .*\)" | tr " " "\n" | grep -v b | sed 's/,//g' | tail -n 1

Dominant language
Ruby
Stars
196
Forks
372
Avg merge
1d 18m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from voxpupuli/puppet-python

All issues in voxpupuli/puppet-python

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.