Ensure curl package

Open
#536 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Domain
devops, infrastructure

Research direction

Inspect manifests/pip/bootstrap.pp at the two linked locations around lines 36 and 52. Check how the package requirements and Exec commands are defined; done means curl is explicitly required and the commands cannot report success when curl is missing.

Written by the indexing model from the issue text.

Description

https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L36

This assumes curl is installed, but it should be added as a package requirement.
Furthermore the command will return a 0 successful code if the python binary is present but curl is not, masking the failure and making puppet think the Exec resource applied successfully.

Same here:
https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L52

Dominant language
Ruby
Stars
196
Forks
372
Avg merge
1d 18m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from voxpupuli/puppet-python

All issues in voxpupuli/puppet-python

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.