Virtualenv>=20.0.0 has new version command output breaking virtualenv_version fact
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Read lib/facter/virtualenv_version.rb and reproduce the fact with both virtualenv --version outputs shown in the issue. Update the parsing so virtualenv_version is defined for versions before and from 20.0.0, then verify the fact no longer raises the reported nil error.
Written by the indexing model from the issue text.
Description
Affected Puppet, Ruby, OS and module versions/distributions
We are running old everything, but the facter fact, https://github.com/voxpupuli/puppet-python/blob/master/lib/facter/virtualenv_version.rb, hasn't been changed in a while.
How to reproduce (e.g Puppet code you use)
Try to use virtualenv_version fact when virtualenv>=20.0.0 is installed
What are you seeing
error while resolving custom fact "virtualenv_version": undefined method `[]' for nil:NilClass
What behaviour did you expect instead
virtualenv_version is defined with a version value.
Any additional information you'd like to impart
This happens because virtualenv>=20.0.0 is a major rewrite and changes the output of the virtualenv --version command.
Old virtualenv:
$ virtualenv --version
16.7.5
New virtualenv:
$ ~/venv/bin/virtualenv --version
virtualenv 20.0.1 from /home/clark/venv/lib/python2.7/site-packages/virtualenv/__init__.pyc
The fact's output parsing will need to be updated to handle both cases.
- Dominant language
- Ruby
- Stars
- 196
- Forks
- 372
- Avg merge
- 1d 18m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from voxpupuli/puppet-python
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
voxpupuli/puppet-python#743 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#721 · 1 reaction ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
voxpupuli/puppet-python#712 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#711 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
voxpupuli/puppet-python#673 · 1 comment ·
All issues in voxpupuli/puppet-python
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100