Pip ensure absent command ! not found

Open
#522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
bash
Domain
devops

Research direction

Inspect manifests/pip.pp around line 223, where the issue reports the unless command is assembled. Confirm how the command is executed when pip is absent, then verify that the check works without the shell reporting ! as a missing command.

Written by the indexing model from the issue text.

Description

Hello

When setting a pip absent I get following:

Could not evaluate: Could not find command '!'

This prob happens because bash is not used as a shell. I resolved this by changing the unless command to.

https://github.com/voxpupuli/puppet-python/blob/master/manifests/pip.pp
line 223
$unless_command = "echo '! ${pip_env} list | grep -i -e \'${grep_regex}\'' | bash"

Dominant language
Ruby
Stars
196
Forks
372
Avg merge
1d 18m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from voxpupuli/puppet-python

All issues in voxpupuli/puppet-python

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.