python::pip falls through to uninstalling the package if ensure doesn't match one of the patterns
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Start with manifests/pip.pp around line 274 and reproduce the provided python::pip resource using an unrecognized ensure value. Done means the resource reports an error for that value and does not run the uninstall action.
Written by the indexing model from the issue text.
Description
Affected Puppet, Ruby, OS and module versions/distributions
- Puppet: 3.7.2
- Ruby: 2.1.5p273
- Distribution: Debian
- Module version: v2.1.1
How to reproduce (e.g Puppet code you use)
python::pip { 'wal-e' :
ensure => 'v1.1.0',
pkgname => 'wal-e',
pip_provider => 'pip',
virtualenv => '/var/local/py-virtual-env/wal-e',
owner => 'root',
extras => ['aws'],
timeout => 1800
}
What are you seeing
python::pip uninstalls the wal-e package because uninstall is the default:
https://github.com/voxpupuli/puppet-python/blob/master/manifests/pip.pp#L274
What behaviour did you expect instead
An error on an unrecognized value instead of a default action of removing the package.
Output log
Notice: /Stage[main]/Nni::Wal_e_virtualenv/Python::Pip[wal-e]/Exec[pip_uninstall_wal-e]/returns: executed successfully
Any additional information you'd like to impart
- Dominant language
- Ruby
- Stars
- 196
- Forks
- 372
- Avg merge
- 1d 18m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from voxpupuli/puppet-python
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
voxpupuli/puppet-python#743 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#721 · 1 reaction ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
voxpupuli/puppet-python#712 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#711 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
voxpupuli/puppet-python#673 · 1 comment ·
All issues in voxpupuli/puppet-python
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100