Regex doesn't work for version which contains '+' symbol
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 52/100
Research direction
Start in puppet-python/manifests/pip.pp at the regexes on lines 136 and 209, using the reported Puppet and module versions as context. Reproduce the ensure_resource example with version 1.8.0+apache.incubating, then verify that the version is accepted and the module no longer attempts to uninstall airflow.
Written by the indexing model from the issue text.
Description
Hi,
Puppet 4.10.0
Module version: v1.18.2
I try install airflow from url but puppet tries to uninstall it.
ensure_resource(python::pip, 'airflow', {url => https://github.airflow/arhive/1.8.0.zip,
pkgname => 'airflow',
ensure => '1.8.0+apache.incubating')
Issue is that your regex doesn't like '+' in the version string '1.8.0+apache.incubating'.
file: puppet-python/manifests/pip.pp
strings:
136 if $ensure =~ /^((19|20)[0-9][0-9]-(0[1-9]|1[1-2])-([0-2][1-9]|3[0-1])|[0-9]+\.\w+\+?\w*(\.\w+)*)$/ {
209 /^((19|20)[0-9][0-9]-(0[1-9]|1[1-2])-([0-2][1-9]|3[0-1])|[0-9]+\.\w+\+?\w*(\.\w+)*)$/: {
Thank Pav
- Dominant language
- Ruby
- Stars
- 196
- Forks
- 372
- Avg merge
- 1d 18m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from voxpupuli/puppet-python
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
voxpupuli/puppet-python#743 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#721 · 1 reaction ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
voxpupuli/puppet-python#712 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
voxpupuli/puppet-python#711 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
voxpupuli/puppet-python#673 · 1 comment ·
All issues in voxpupuli/puppet-python
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100