virtualenv.pp exec unless being overwritten by creates

Open
#338 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
devops

Research direction

Start in virtualenv.pp around line 163 and inspect the exec resource for python_virtualenv_${venv_dir}, focusing on how unless and creates interact. Done means the virtual environment command runs only when intended while retaining the creates-related behavior described in the issue.

Written by the indexing model from the issue text.

Description

Its seems that the unless statement for exec { "python_virtualenv_${venv_dir}": is being overridden by the creates statement. Removing the "creates" param correctly runs the exec command only once.

diff virtualenv.pp /tmp/virtualenv.pp
163a164

  creates     => "${venv_dir}/bin/activate",

Thanks

Dominant language
Ruby
Stars
196
Forks
372
Avg merge
1d 18m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from voxpupuli/puppet-python

All issues in voxpupuli/puppet-python

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.