voxpupuli / voxpupuli/puppet-php
fpm_pools option not working after release 7.0.0
Open
Nobody has claimed this yet.
- Dominant language
- Puppet
- Stars
- 86
- Forks
- 264
- Avg merge
- 29m
- Merged PRs (30d)
- 1
Description
After this change, fpm_pools does not work anymore.
As consequence, this use case is broken too
Version 7.0.0:
class { 'php':
ensure => 'present',
manage_repos => false,
fpm => true,
dev => false,
composer => false,
pear => true,
phpunit => false,
fpm_pools => {},
}
php::fpm::pool { 'www2':
listen => '127.0.1.1:9000',
}
Created pools: www2 ---> correct
Afred 7.0.0:
class { 'php':
ensure => 'present',
manage_repos => false,
fpm => true,
dev => false,
composer => false,
pear => true,
phpunit => false,
fpm_pools => {},
}
php::fpm::pool { 'www2':
listen => '127.0.1.1:9000',
}
Created pools: www and www2 ----> wrong
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the linked commit 75c5e4e with the prior fpm_pools behavior and reproduce the two manifests shown in the issue. Trace how the php class and php::fpm::pool resource create pools; done means the explicit www2 pool is created without the unintended www pool and the one-pool-per-user use case works again.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100