Private class test should use `assert_private()`

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 3.8
• Ruby: 1.9.3
• Distribution: Ubuntu
• Module version: 5576e072b32c989f1cd6a2e7551a8d66285d6cd2

What are you seeing

The test that insures some class/type are private is not the same everywhere

Some class/type use this test:

  if ! defined(Class['php::fpm']) {
    warning('php::fpm::service is private')
  }

See https://github.com/voxpupuli/puppet-php/search?q=%22defined%28Class%22

• manifests/fpm/service.pp
• manifests/fpm.pp
• manifests/fpm/pool.pp
• manifests/extension.pp

From what I understand only manifests/fpm/pool.pp should use it (based on the warning message warning('You must include the php base class before using any php defined resources'))
With the current version of the code, user can call some private classes directly.

The correct test for privacy should be:

  if $caller_module_name != $module_name {
    warning('php::fpm::config is private')
  }

(this code is already used in some other places inside this module)

Read manifests/fpm/service.pp, manifests/fpm.pp, manifests/fpm/pool.pp, and manifests/extension.pp, then compare their privacy checks with existing caller_module_name uses. Verify that each intended private class or type rejects direct use while the base-class behavior remains as described.