voxpupuli / voxpupuli/puppet-patching_as_code

When the patching process fails, the "post patching command" will fail to run due to a dependancy.

Open
#121 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Puppet
Stars
10
Forks
18
Avg merge
6h 10m
Merged PRs (30d)
2

Description

In our patching process, we utilise the "before and after" patching command. We do this to gracefully stop services on a server, let the system patch, and then start them once patching is complete.

On a recent patching cycle, the "before" patching command executed as normal, however there was a issue with the "patching" part of the process, which got a 404 one of the linux patches.

Image

this then caused anything further down the process to be aborted, including the start command

Image

Is there any possibility to make the start process run even if the "patching" part of the process fails, and remove the dependancy on every step completing successfully? e.g. if the pre-patch command runs, the post-patch command must always run.

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the before, patching, and after command workflow and how a patch failure stops later steps. Done means that when the before command runs, the after command still runs even if patching fails, with coverage for the failure path.

Written by the indexing model from the issue text.

Assessment

Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.