voidzero-dev / voidzero-dev/vite-task

fspy_preload_unix: execl with 32+ arguments aborts on an out-of-bounds NULL terminator write

Open
#699 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
466
Forks
42
Avg merge
1d 15h
Merged PRs (30d)
19

Description

Summary

When fspy tracks a Unix child process that calls execl, execlp, or execle with at least 32 non-NULL argv entries (including arg0), the preload interposer aborts the child process.

In with_argv, the heap branch creates a slice with exactly argc elements, then writes the required NULL terminator at out[argc]:

let ptr = libc::malloc(argc * size_of::<*const c_char>());
let out = slice::from_raw_parts_mut(ptr.cast(), argc);
// ...
out[argc].write(core::ptr::null());

The valid indices are 0..argc, so this deterministically panics. Because the panic occurs inside an extern "C" interposer, it cannot unwind and the process aborts.

Reproduction

Reproduced against 44186c8 on macOS through the real fspy preload path. A temporary fspy integration test called libc::execl("/usr/bin/true", ...) from inside track_fn! and was run with:

cargo test --offline -p fspy --test execl_many_args -- --nocapture
Non-NULL argv entries, including arg0 Result
31 Passes; uses the fixed 32-slot stack storage
32 Aborts; heap slice has length 32 and writes index 32

Observed failure:

with_argv.rs:52:5:
index out of bounds: the len is 32 but the index is 32

panic in a function that cannot unwind
thread caused non-unwinding panic. aborting.

Trigger flow

cached/auto-tracked task
  -> fspy preload is injected into a child process
  -> the tracked native process calls execl/execlp/execle
  -> with_argv rebuilds argv
  -> argc >= 32 selects heap storage
  -> out[argc] writes past the slice boundary
  -> non-unwinding panic aborts the child

This is not triggered merely because a command has 32 arguments: the tracked program must use one of the variadic execl* APIs. Calls through execv/execve, posix_spawn, and most common high-level process APIs do not use this path. That makes the scenario uncommon, but deterministic for native tools that invoke execl* with sufficiently many arguments.

Suggested coverage

Allocate space for argc + 1 entries and add real preload regression cases at the 31/32/33 boundary for execl, execlp, and execle.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with with_argv.rs and the heap branch reached when argc is at least 32; reproduce the boundary using cargo test --offline -p fspy --test execl_many_args -- --nocapture. Confirm the preload path handles 31, 32, and 33 non-NULL entries for execl, execlp, and execle without aborting, then run the regression cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.