voidzero-dev / voidzero-dev/vite-plus

fix(migrate): tolerate nested npm overrides during bootstrap detection

Open
#2,002 0 comments 0 reactions 1 assignee Claimed by @fengmk2 View on GitHub
bug
Dominant language
Rust
Stars
5.8k
Forks
262
Avg merge
1d 34m
Merged PRs (30d)
135

Description

`detectVitePlusBootstrapPending` assumes npm `overrides` values are strings, but npm supports nested override objects. A valid package.json such as this can throw during migration because the bootstrap detection calls string methods like `.startsWith()` on the override value:

```json
{
"overrides": {
"vite": {
"rollup": "..."
}
}
}
```

Expected behavior:

- Migration should not crash when `overrides.vite` or `overrides.vitest` is a nested object.
- Non-string override values should be treated as not satisfying the Vite+ override and then handled safely by the migration rewrite logic.
- Add a regression test covering a nested npm override under a managed key.

Suggested test:

Create an npm fixture with nested overrides:

```json
{
"devDependencies": {
"vite-plus": "0.1.x"
},
"overrides": {
"vite": {
"rollup": "^4.0.0"
}
}
}
```

Run:

```bash
vp migrate --no-interactive
```

Assert that migration completes or reports an actionable migration error, but does not throw a TypeError from bootstrap detection.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.