voidzero-dev / voidzero-dev/vite-plus

fix(migrate): detect Yarn PnP config even when env overrides nodeLinker

Open
#2,001 0 comments 0 reactions 1 assignee Claimed by @fengmk2 View on GitHub
bug
Dominant language
Rust
Stars
5.8k
Forks
262
Avg merge
1d 34m
Merged PRs (30d)
135

Description

`vp migrate` currently treats `YARN_NODE_LINKER=node-modules` as enough to skip Yarn PnP handling. However, if the repository itself has `.yarnrc.yml` with `nodeLinker: pnp`, migration can complete successfully while leaving unsupported PnP config in the project. Future installs without that environment override will return to PnP mode.

Expected behavior:

- If `.yarnrc.yml` explicitly sets `nodeLinker: pnp`, migration should not silently pass just because `YARN_NODE_LINKER=node-modules` is set.
- Preferably, migration should stop and ask the user to change the project config manually, or apply the existing node-modules conversion flow if that is the intended behavior.
- `YARN_NODE_LINKER=pnp` should still hard-block migration as today.

Suggested test:

Create a Yarn Berry fixture with:

```yaml
# .yarnrc.yml
nodeLinker: pnp
```

Run migrate with:

```bash
YARN_NODE_LINKER=node-modules vp migrate --no-interactive
```

Assert that migration does not report the project as successfully migrated while leaving `nodeLinker: pnp` unchanged.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.